mifiel/document.py (1)

43-70: ⚠️ Potential issue | 🔴 Critical

Fix the mixed dict/tuple-list payload construction.

Line 43 leaves data as a dict, but lines 48 and 52 call data.append(...); Document.create() will raise AttributeError before sending the request. Keep scalar kwargs in a dict, collect repeated form fields separately, then convert to a list of tuples before calling process_request.

Proposed fix

    data = kwargs.copy()
+   viewers = data.pop('viewers', None)
+   form_data = []
    for index, item in enumerate(signatories):
      for key, val in item.items():
        if key == 'allowed_signature_methods' and isinstance(val, list):
          for method in val:
-           data.append(
+           form_data.append(
              (f'signatories[{index}][{key}][]', method)
            )
        else:
-           data.append(
+           form_data.append(
              (f'signatories[{index}][{key}]', val)
            )
 
-   if 'viewers' in data:
-     viewers = data.pop('viewers')
+   if viewers is not None:
      for index, item in enumerate(viewers):
        for key, val in item.items():
-         data.update(
-           {'viewers[' + str(index) + '][' + str(key) + ']': val}
+         form_data.append(
+           (f'viewers[{index}][{key}]', val)
          )
 
    if 'callback_url' in kwargs: data['callback_url'] = kwargs.get('callback_url')
    if file:
      mimetype = mimetypes.guess_type(file)[0]
      _file = open(file, 'rb')
      file = {'file': (basename(_file.name), _file, mimetype)}
    if dhash:
      data['original_hash'] = data.pop('dhash')
+   data = list(data.items()) + form_data
 
    doc = Document(client)

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@mifiel/document.py` around lines 43 - 70, The payload mixes a dict and list
operations causing AttributeError; in the function building the request payload
(in mifiel/document.py around the signatories/viewers handling used by
Document.create()), keep scalar fields in a dict (e.g., data_dict) and
accumulate repeated form fields (signatories' allowed_signature_methods and
per-signatory entries, viewers entries) into a separate list of tuples (e.g.,
form_items); when done merge them by extending form_items with dict items
converted to (key,value) tuples and use that list for process_request; also
ensure file handling and dhash -> original_hash mapping write into the dict/form
appropriately and that callback_url is set on the dict before final conversion.